Skip to content

fix(metrics): flush metrics when data points array reaches max size #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

As reported in the linked issue prior to this PR the Metrics utility allowed to add a number of data points greater than the current 100 limit set by the EMF specification. This PR fixes the issue by ensuring that when a new data point is added and the limit is reached, all the stored metrics are flushed right away.

Related issues, RFCs

Issue number: fixes #1529

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi requested a review from a team June 22, 2023 21:51
@dreamorosi dreamorosi self-assigned this Jun 22, 2023
@dreamorosi dreamorosi linked an issue Jun 22, 2023 that may be closed by this pull request
@boring-cyborg boring-cyborg bot added metrics This item relates to the Metrics Utility tests PRs that add or change tests labels Jun 22, 2023
@pull-request-size pull-request-size bot added the size/M PR between 30-99 LOC label Jun 22, 2023
@dreamorosi
Copy link
Contributor Author

@github-actions github-actions bot added the bug Something isn't working label Jun 22, 2023
@dreamorosi dreamorosi merged commit 24c247c into main Jun 23, 2023
@dreamorosi dreamorosi deleted the 1529-bug-prevent-a-single-metric-have-more-than-100-data-points branch June 23, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working metrics This item relates to the Metrics Utility size/M PR between 30-99 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Prevent a single metric have more than 100 data points
1 participant